Fix for Empty except#817
Merged
Andrey1994 merged 1 commit intomasterfrom Apr 26, 2026
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General fix: replace bare
except:+passwith targeted exception handling and an explanatory comment, so only expected failures are ignored.Best fix here (without changing behavior): in
python_package/brainflow/ml_model.py, insideMLModuleDLL.__init__, change:except:toexcept (AttributeError, OSError):passbut add a clear explanatory comment stating why it is safe to continue.Why these exceptions:
AttributeError:os.add_dll_directorymay not exist on some Python/platform combinations.OSError: call can fail depending on runtime environment/permissions/path handling.No imports or new methods are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.